The server init method is different from others
Reported by dj2 | July 16th, 2008 @ 02:59 PM
I used a hash in the server init method to allow saying :server => 'blah.com', :port => 80 where as in all other methods I just use a parameter list.
This should be made consistent either by changing the server create method or by changing all other methods to take a hash.
Comments and changes to this ticket
-
dj2 July 16th, 2008 @ 03:37 PM
A quick patch that converts the examples and tests over to the hash options. Still trying to decide which I like better. I think I'm leaning towards the hash as, while more verbose, it's cleaner I think
-
dj2 July 16th, 2008 @ 04:45 PM
Another test/example change. This time the api-hybrid.diff has any required parameters as non-named and optional parameters as named.
I think this makes sense as it cuts down in the repetition of putting in names for required things but makes the optionals nicer in that you can drop un-needed stuff.
-
dj2 July 16th, 2008 @ 05:17 PM
hybrid-api-implementation.diff is the full gem converted over to the hybrid api.
-
dj2 July 16th, 2008 @ 09:49 PM
The hybrid approach has been committed. I bumped the version to 0.0.2 as the API changed.
Commit: 4efab2f4f87af5972786766c60cccaa8c38c7264
-
dj2 July 16th, 2008 @ 09:49 PM
- → State changed from “new” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
A simple Ruby wrapper around the PostRank API.
